{ "cells": [ { "cell_type": "code", "execution_count": 1, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:56:26.596390Z", "start_time": "2024-04-17T14:56:25.311090Z" } }, "outputs": [ { "name": "stderr", "output_type": "stream", "text": [ "/tmp/ipykernel_1235094/325804709.py:1: DeprecationWarning: \n", "Pyarrow will become a required dependency of pandas in the next major release of pandas (pandas 3.0),\n", "(to allow more performant data types, such as the Arrow string type, and better interoperability with other libraries)\n", "but was not found to be installed on your system.\n", "If this would cause problems for you,\n", "please provide us feedback at https://github.com/pandas-dev/pandas/issues/54466\n", " \n", " import pandas as pd\n" ] } ], "source": [ "import pandas as pd\n", "import numpy as np\n", "import os\n", "from tqdm import tqdm\n", "from sklearn.model_selection import train_test_split\n", "from suno_utils.utils.s3 import download_s3_files\n", "import sys\n", "from collections import defaultdict\n", "from suno_utils.utils.text import (\n", " write_jsonl,\n", " read_jsonl,\n", " write_json,\n", " read_json,\n", ")\n", "import shutil\n", "import ast\n", "from preference_helper import *\n", "from preference_data_preparation import make_dataset\n", "\n", "sys.path.insert(0, \"/home/tony/Work/glockenspiel/sunoGPT/scripts/\")\n", "\n", "from data_preparation_7b import *\n", "import numpy as np\n", "\n", "pd.set_option('display.max_rows', 500)\n", "pd.set_option('display.max_columns', 500)\n", "pd.set_option('display.width', 1000)" ] }, { "cell_type": "code", "execution_count": 2, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:56:26.634482Z", "start_time": "2024-04-17T14:56:26.597969Z" } }, "outputs": [], "source": [ "OUT_DATA_DIR = \"/app/suno/data/dpo/7v_v2_mix_v0v1/\"\n", "# OUT_DATA_DIR = \"/home/tony/Data/test/7v_v6_full/\"\n", "os.makedirs(OUT_DATA_DIR, exist_ok=True)\n", "shutil.copyfile(\"/app/suno/data/dpo/7v_v1_full/tokenizer_60k.json\", os.path.join(OUT_DATA_DIR, \"tokenizer_60k.json\"))\n", "NPZ_DIR = \"/app/suno/data/dpo/7b_recycle_npz\"" ] }, { "cell_type": "code", "execution_count": 3, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:56:26.662997Z", "start_time": "2024-04-17T14:56:26.635548Z" } }, "outputs": [], "source": [ "# df_origin = pd.read_csv(\"/home/tony/Data/Preference/7b_v1/interesting_clips.csv\")\n", "# df_origin[df_origin[\"id\"] == \"75f69d46-1d81-4327-9253-a8a4886777d1\"]\n", "# df_origin[df_origin[\"request_id\"] == \"9414f356-88d6-40ba-b95e-9f4c5004a4aa\"]\n", "# df_origin[df_origin[\"request_id\"] == \"b2a150c1-f058-4bff-a013-1961e574631d\"]\n", "# df_origin[df_origin[\"id\"] == \"574ba431-18a1-4e28-ac7c-d3e401dba6fe\"]" ] }, { "cell_type": "code", "execution_count": 4, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:56:59.585365Z", "start_time": "2024-04-17T14:56:26.664666Z" } }, "outputs": [ { "data": { "text/plain": [ "(1822704, 41)" ] }, "execution_count": 4, "metadata": {}, "output_type": "execute_result" } ], "source": [ "df = pd.read_csv(\"/home/tony/Data/Preference/7b_v0/interesting_clips.csv\") # , engine='python')\n", "df.shape\n", "# v0: (68746, 31)\n", "# v5: (938008, 37)\n", "# v6: (1097024, 38)\n", "# v21: (1822704, 41)\n", "# r1 \n", "# v2: 2620268 (pre fixes...lots of imperfections...)\n", "# v3: 1552512" ] }, { "cell_type": "code", "execution_count": 5, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:57:01.788976Z", "start_time": "2024-04-17T14:56:59.586524Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "780536\n", "780536\n", "pre-downloaded df (1822704, 41)\n", "downloaded df (208478, 41)\n" ] } ], "source": [ "converted_paths = os.listdir(NPZ_DIR)\n", "print(len(converted_paths))\n", "\n", "converted_paths = set([f.replace(\".npz\", \"\") for f in converted_paths])\n", "print(len(converted_paths))\n", "\n", "print(\"pre-downloaded df\", df.shape)\n", "df[df[\"s3_id\"].isin(converted_paths)].shape\n", "df = df[df[\"s3_id\"].isin(converted_paths)].copy()\n", "print(\"downloaded df\", df.shape)" ] }, { "cell_type": "code", "execution_count": 6, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:57:02.057126Z", "start_time": "2024-04-17T14:57:01.797100Z" } }, "outputs": [ { "data": { "text/plain": [ "is_7b\n", "True 208478\n", "Name: count, dtype: int64" ] }, "execution_count": 6, "metadata": {}, "output_type": "execute_result" } ], "source": [ "df[\"is_7b\"] = df[\"model_name\"].str.contains(\"v3\")\n", "df[\"is_7b\"].value_counts()" ] }, { "cell_type": "markdown", "metadata": {}, "source": [ "# LET's do the data prep" ] }, { "cell_type": "code", "execution_count": 7, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:57:02.059673Z", "start_time": "2024-04-17T14:57:02.058278Z" } }, "outputs": [], "source": [ "date_cut = '2024-03-22 04:30:00'" ] }, { "cell_type": "code", "execution_count": 8, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:57:02.220728Z", "start_time": "2024-04-17T14:57:02.060658Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "preference model_name \n", "False chirp-v3-engine-v0 54802\n", " chirp-v3-engine-d 43955\n", " chirp-v3-engine-i 5212\n", " chirp-v3-engine-i-d 270\n", "True chirp-v3-engine-d 61388\n", " chirp-v3-engine-v0 36210\n", " chirp-v3-engine-i 6424\n", " chirp-v3-engine-i-d 217\n", "Name: count, dtype: int64\n", "(208478, 42)\n", "(196355, 42)\n" ] } ], "source": [ "# # let's also kick out the ... ipo and ipo-dpoed model for now?\n", "print(df.groupby([\"preference\"])[\"model_name\"].value_counts())\n", "print(df.shape)\n", "# df = df[df[\"model_name\"].isin([\"chirp-v3-engine-d\", \"chirp-v3-engine-v0\", \"chirp-v3-engine-i\"])]\n", "df = df[df[\"model_name\"].isin([\"chirp-v3-engine-d\", \"chirp-v3-engine-v0\"])]\n", "# df = df[df[\"model_name\"].isin([\"chirp-v3-engine-v0\"])]\n", "print(df.shape)" ] }, { "cell_type": "code", "execution_count": 9, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:57:02.431600Z", "start_time": "2024-04-17T14:57:02.222057Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "(196355, 42)\n", "(187230, 42)\n", "preference model_name \n", "False chirp-v3-engine-v0 51995\n", " chirp-v3-engine-d 41620\n", "True chirp-v3-engine-d 58856\n", " chirp-v3-engine-v0 34759\n", "Name: count, dtype: int64\n" ] } ], "source": [ "print(df.shape)\n", "df = df[\n", " df[\"request_id\"].isin(\n", " df[\"request_id\"].value_counts().index[df[\"request_id\"].value_counts() == 2]\n", " )\n", "]\n", "print(df.shape)\n", "print(df.groupby([\"preference\"])[\"model_name\"].value_counts())\n", "assert df.shape[0] == df[\"request_id\"].nunique() * 2" ] }, { "cell_type": "code", "execution_count": 10, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:57:41.846732Z", "start_time": "2024-04-17T14:57:02.432909Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "unique_requests 93615\n" ] } ], "source": [ "# Let's use the old selection for now -- for quality assurance\n", "# expand the metadata columns -- this takes forever...~ 6 mins\n", "test_slice = df[\"metadata\"].apply(lambda x: ast.literal_eval(x))\n", "test_slice_series = test_slice.apply(pd.Series)\n", "df = pd.concat([df, test_slice_series], axis=1, join=\"inner\")\n", "print(\"unique_requests\", df[\"request_id\"].nunique())" ] }, { "cell_type": "code", "execution_count": 11, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:57:41.850477Z", "start_time": "2024-04-17T14:57:41.847927Z" } }, "outputs": [ { "data": { "text/plain": [ "Index(['id', 'created_at', 'updated_at', 'time_used', 'metadata', 'user_id', 'status', 'discord_message_id', 'prompt_id', 'request_id', 'is_generated', 's3_id', 'upvote_count', 'batch_index', 'model_name', 'prompt_text', 'daily_theme_id', 'is_deleted', 'image_s3_id', 'is_public', 'dislike_count', 'flag_count', 'play_count', 'skip_count', 'title', 'is_public_approved', 'slug', 'is_in_playlist', 'continued_parent', 'user_n_clips', 'upvoted', 'has_continued', 'part_of_concat', 'downvoted', 'has_action', 'preference', 'has_gpt_prompt', 'total_start_s', 'total_clip_s', 'concat_play_counts', 'concat_in_playlist', 'is_7b', 'tags', 'type', 'prompt', 'stream', 'history', 'options', 'duration', 'experiment', 'gpt_prompt', 'continue_at', 'refund_credits', 'audio_prompt_id', 'make_instrumental', 'continued_from_prompt', 'gpt_description_prompt', 'image_s3_id', 'concat_history', 'extra', 'promotion', 'check_copyright', 'check_artist_names', 'error_type', 'error_message', 'title'], dtype='object')" ] }, "execution_count": 11, "metadata": {}, "output_type": "execute_result" } ], "source": [ "df.columns" ] }, { "cell_type": "code", "execution_count": 12, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:57:42.205212Z", "start_time": "2024-04-17T14:57:41.851521Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "unique_requests 93615\n" ] } ], "source": [ "# double check we removed the gpt prompted ones for now\n", "df = df[df[\"has_gpt_prompt\"] == False]\n", "print(\"unique_requests\", df[\"request_id\"].nunique())" ] }, { "cell_type": "code", "execution_count": 13, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:57:46.667244Z", "start_time": "2024-04-17T14:57:42.207974Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "45299\n", "good_continue_at\n", "True 187185\n", "False 45\n", "Name: count, dtype: int64\n", "preference\n", "False 93615\n", "True 93615\n", "Name: count, dtype: int64 is_7b\n", "True 187230\n", "Name: count, dtype: int64 model_name\n", "chirp-v3-engine-d 100476\n", "chirp-v3-engine-v0 86754\n", "Name: count, dtype: int64 preference model_name \n", "False chirp-v3-engine-v0 51995\n", " chirp-v3-engine-d 41620\n", "True chirp-v3-engine-d 58856\n", " chirp-v3-engine-v0 34759\n", "Name: count, dtype: int64\n" ] } ], "source": [ "# get the original duration of the clips, if they are concacted\n", "df[\"original_duration_s\"] = df[\"total_start_s\"] + df[\"duration\"]\n", "\n", "# classify the continue at behavoirs by the duration choice\n", "audio_prompt_id_to_continue_at = {}\n", "for _, row in df[~df[\"audio_prompt_id\"].isna()].iterrows():\n", " audio_prompt_id = row[\"audio_prompt_id\"]\n", " if audio_prompt_id not in audio_prompt_id_to_continue_at:\n", " audio_prompt_id_to_continue_at[audio_prompt_id] = row[\"continue_at\"]\n", " else:\n", " # pick the max\n", " audio_prompt_id = max(\n", " audio_prompt_id_to_continue_at[audio_prompt_id], row[\"continue_at\"]\n", " )\n", "print(len(audio_prompt_id_to_continue_at))\n", "df[\"has_continue_and_start_continue_at\"] = df[\"id\"].apply(\n", " lambda x: audio_prompt_id_to_continue_at.get(x)\n", ")\n", "# we want continue at to be at least half of the clip...\n", "df[\"good_continue_at\"] = (\n", " (df[\"has_continue_and_start_continue_at\"] / df[\"duration\"]) > 0.9\n", ") | df[\"has_continue_and_start_continue_at\"].isna()\n", "print(df[\"good_continue_at\"].value_counts())\n", "\n", "\n", "print(\n", " df[\"preference\"].value_counts(),\n", " df[\"is_7b\"].value_counts(),\n", " df[\"model_name\"].value_counts(),\n", " df.groupby([\"preference\"])[\"model_name\"].value_counts()\n", ")\n", "\n", "df = df.sort_values(by=[\"request_id\", \"preference\"])\n", "df[\"duration_rel_diff\"] = df['duration'].diff() \n", "df[\"play_rel_diff\"] = df['play_count'].diff() " ] }, { "cell_type": "code", "execution_count": 14, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:57:46.901840Z", "start_time": "2024-04-17T14:57:46.668937Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "negative 93528 positive 78463\n", "total pair requests 93615 selected pair requests 78394 frac 0.837\n" ] } ], "source": [ "normal_pos_play_count = 7\n", "# this is lower, cause a concat is probably already ensuring that it is good\n", "concat_pos_play_count = 2\n", "# this is a filter on the concated clip\n", "concat_total_play_count = 5\n", "\n", "neg_filter_selection_mask = (\n", " (df[\"preference\"] == False) # get basics aligned\n", " & (df[\"play_count\"] >= 1) # has to be played once\n", " & (df[\"play_count\"] <= 3) # if it is actually bad, shouldn't be listened often\n", " & (df[\"duration\"] >= 10) # can't be too short, otherwise it is obvious\n", " & (df[\"duration\"] <= 120) # can't be badly long\n", " & (df[\"has_continue_and_start_continue_at\"].isna()) # won't have any continues\n", " # & (df[\"dislike_count\"] >= 1) # this is kinda strict\n", " # & (\n", " # (df_slice[\"is_in_playlist\"] == False)\n", " # & (df_slice[\"concat_in_playlist\"] == False)\n", " # ) # can't be part of a playlist -- otherwise there are some like signal in it?\n", " & (\n", " ((df[\"is_7b\"] == False) & (df[\"play_count\"] >= 2) & (df[\"duration\"] >= 10))\n", " | ((df[\"is_7b\"] == True) & (df[\"play_count\"] >= 1))\n", " )\n", ")\n", "pos_filter_selectin_mask = (\n", " (df[\"preference\"] == True) # get basics aligned\n", " & (\n", " df[\"good_continue_at\"] == True\n", " ) # if continue, needs to continue off a certain percentage\n", " & (\n", " ((df[\"play_count\"] >= 1) & (df[\"is_7b\"] == True))\n", " | ((df[\"play_count\"] >= 10) & (df[\"is_7b\"] == False))\n", " )\n", " & (\n", " (\n", " (df[\"part_of_concat\"] == True)\n", " & (df[\"play_count\"] >= concat_pos_play_count)\n", " & (df[\"concat_play_counts\"] >= concat_total_play_count)\n", " )\n", " | (\n", " (df[\"part_of_concat\"] == False)\n", " & (df[\"play_count\"] >= normal_pos_play_count)\n", " )\n", " )\n", " & (df[\"play_rel_diff\"] >= 0) # this is more like quality assurance\n", " & (df[\"duration\"] >= 10) # can't be too short, otherwise it is obvious\n", " & (df[\"duration\"] <= 120) # can't be badly long\n", " & (df[\"dislike_count\"] == 0) # can't have dislikes\n", " & (df[\"flag_count\"] == 0) # can't have issues\n", " & (df[\"user_n_clips\"] >= 20) # user needs to have genereated at least 20\n", " # & (df[\"duration_rel_diff\"] < 10) # positive isn't just longer\n", " # & (df[\"upvote_count\"] >= 1)\n", ")\n", "print(\n", " \"negative\",\n", " sum(neg_filter_selection_mask),\n", " \"positive\",\n", " sum(pos_filter_selectin_mask),\n", ")\n", "\n", "neg_filter_requests = df[neg_filter_selection_mask][\"request_id\"].unique()\n", "pos_filter_requests = df[pos_filter_selectin_mask][\"request_id\"].unique()\n", "# looking for very strong signal here:\n", "# listen to the positive/negative more than once\n", "# disliked one of the clips\n", "unique_requests = set(pos_filter_requests).intersection(neg_filter_requests)\n", "print(\n", " \"total pair requests\",\n", " df[\"request_id\"].nunique(),\n", " \"selected pair requests\",\n", " len(unique_requests),\n", " f\"frac {len(unique_requests) / df['request_id'].nunique():.3f}\",\n", ")" ] }, { "cell_type": "code", "execution_count": 15, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:57:47.106724Z", "start_time": "2024-04-17T14:57:46.903145Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "requests 78394 clips 156788 total khrs 2.963; N gpus for 1000 iters 4.900; n unique users 13719\n" ] } ], "source": [ "df_slice = df[df[\"request_id\"].isin(set(unique_requests))].copy()\n", "print(\n", " \"requests\",\n", " df_slice[\"request_id\"].nunique(),\n", " \"clips\",\n", " df_slice.shape[0],\n", " f\"total khrs {sum(df_slice['duration'] / 3600 / 1000):.3f};\",\n", " f\"N gpus for 1000 iters {df_slice.shape[0] / 8 / 4 / 1000:.3f};\",\n", " f\"n unique users {df_slice['user_id'].nunique()}\",\n", ")\n", "# 76171 152342 total khrs 2.880 n gpus for 1250 iters 3.809" ] }, { "cell_type": "code", "execution_count": 16, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:57:47.132804Z", "start_time": "2024-04-17T14:57:47.108040Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "positive in playlist (21127, 71)\n" ] } ], "source": [ "test_mask = (df_slice[\"preference\"] == True) & (\n", " (df_slice[\"is_in_playlist\"] == True) | (df_slice[\"concat_in_playlist\"] == True)\n", ")\n", "print(\"positive in playlist\", df_slice[test_mask].shape)" ] }, { "cell_type": "code", "execution_count": 17, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:57:47.175495Z", "start_time": "2024-04-17T14:57:47.134077Z" } }, "outputs": [], "source": [ "# interesting_clips_must_be_positive_mask = (\n", "# (df_slice[\"upvoted\"] == True)\n", "# | (df_slice[\"has_action\"] == True)\n", "# | (df_slice[\"part_of_concat\"] == True)\n", "# )\n", "# interesting_clips_must_be_not_negative_mask = (df_slice[\"downvoted\"] == False) # & (df_slice[\"dislike_count\"] < 1)\n", "# interesting_clips_mask = interesting_clips_must_be_positive_mask & interesting_clips_must_be_not_negative_mask\n", "# assert interesting_clips_mask.eq(df_slice[\"preference\"]).all()" ] }, { "cell_type": "code", "execution_count": 18, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:57:47.242912Z", "start_time": "2024-04-17T14:57:47.176581Z" } }, "outputs": [], "source": [ "# BREAK" ] }, { "cell_type": "markdown", "metadata": {}, "source": [ "# Load v2" ] }, { "cell_type": "code", "execution_count": 19, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:58:19.062115Z", "start_time": "2024-04-17T14:57:47.243844Z" } }, "outputs": [ { "name": "stderr", "output_type": "stream", "text": [ "/tmp/ipykernel_1235094/3943746982.py:1: DtypeWarning: Columns (3,10,12,13,17,19,25,27,28,29,30) have mixed types. Specify dtype option on import or set low_memory=False.\n", " df_v2 = pd.read_csv(\"/home/tony/Data/Preference/v1/interesting_clips.csv\")\n" ] } ], "source": [ "df_v2 = pd.read_csv(\"/home/tony/Data/Preference/v1/interesting_clips.csv\")" ] }, { "cell_type": "code", "execution_count": 20, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:58:20.992432Z", "start_time": "2024-04-17T14:58:19.063774Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "3519009\n" ] } ], "source": [ "converted_v2_paths = os.listdir(\"/app/suno/data/dpo/7b_npz\")\n", "converted_v2_paths = set([f.replace(\".npz\", \"\") for f in converted_v2_paths])\n", "print(len(converted_v2_paths))" ] }, { "cell_type": "code", "execution_count": 21, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:58:26.795242Z", "start_time": "2024-04-17T14:58:20.993620Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "pre-downloaded df (1706214, 31)\n", "downloaded df (1706204, 31)\n" ] } ], "source": [ "print(\"pre-downloaded df\", df_v2.shape)\n", "df_v2[df_v2[\"s3_id\"].isin(converted_v2_paths)].shape\n", "df_v2 = df_v2[df_v2[\"s3_id\"].isin(converted_v2_paths)].copy()\n", "print(\"downloaded df\", df_v2.shape)" ] }, { "cell_type": "code", "execution_count": 22, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:58:27.085752Z", "start_time": "2024-04-17T14:58:26.796518Z" } }, "outputs": [], "source": [ "assert df_v2.shape[0] == df_v2[\"request_id\"].nunique() * 2" ] }, { "cell_type": "code", "execution_count": 23, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:58:28.354153Z", "start_time": "2024-04-17T14:58:27.087425Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "853102 135358\n" ] } ], "source": [ "neg_filter_selection_mask_v2 = (df_v2[\"dislike_count\"] > 0)\n", "pos_filter_selectin_mask_v2 = (df_v2[\"play_count\"] > 1)\n", "neg_filter_requests_v2 = df_v2[neg_filter_selection_mask_v2][\"request_id\"].unique()\n", "pos_filter_requests_v2 = df_v2[pos_filter_selectin_mask_v2][\"request_id\"].unique()\n", "# looking for very strong signal here: \n", "# listen to the positive/negative more than once\n", "# disliked one of the clips\n", "unique_requests_v2 = set(pos_filter_requests_v2).intersection(neg_filter_requests_v2)\n", "print(df_v2[\"request_id\"].nunique(), len(unique_requests_v2))" ] }, { "cell_type": "code", "execution_count": 24, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:58:28.689751Z", "start_time": "2024-04-17T14:58:28.355415Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "(270716, 31)\n" ] } ], "source": [ "df_slice_v2 = df_v2[df_v2[\"request_id\"].isin(set(unique_requests_v2))].copy()\n", "print(df_slice_v2.shape)" ] }, { "cell_type": "code", "execution_count": 25, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:58:43.035321Z", "start_time": "2024-04-17T14:58:28.691006Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "135358\n", "(270716, 31)\n" ] } ], "source": [ "df_slice_v2[\"has_gpt_prompt\"] = df_slice_v2[\"metadata\"].apply(lambda x: ast.literal_eval(x).get(\"gpt_description_prompt\", None) is not None)\n", "final_filtered_requests_v2 = df_slice_v2[~df_slice_v2[\"has_gpt_prompt\"]][\"request_id\"].unique()\n", "print(len(final_filtered_requests_v2))\n", "df_slice_v2 = df_v2[df_v2[\"request_id\"].isin(set(final_filtered_requests_v2))].copy()\n", "print(df_slice_v2.shape)" ] }, { "cell_type": "code", "execution_count": 26, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:59:35.914736Z", "start_time": "2024-04-17T14:58:43.036503Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "unique_requests 135358\n" ] } ], "source": [ "test_slice_v2 = df_slice_v2[\"metadata\"].apply(lambda x: ast.literal_eval(x))\n", "test_slice_series_v2 = test_slice_v2.apply(pd.Series)\n", "df_slice_v2 = pd.concat([df_slice_v2, test_slice_series_v2], axis=1, join=\"inner\")\n", "print(\"unique_requests\", df_slice_v2[\"request_id\"].nunique())" ] }, { "cell_type": "code", "execution_count": 27, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:59:35.966532Z", "start_time": "2024-04-17T14:59:35.938030Z" } }, "outputs": [], "source": [ "# BREAK" ] }, { "cell_type": "code", "execution_count": 28, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:59:36.099627Z", "start_time": "2024-04-17T14:59:35.974929Z" } }, "outputs": [], "source": [ "df_slice = df_slice.reset_index(drop=True)\n", "\n", "df_slice_v2 = df_slice_v2.reset_index(drop=True)\n", "\n", "df_slice = df_slice.loc[:, ~df_slice.columns.duplicated()]\n", "\n", "df_slice_v2 = df_slice_v2.loc[:, ~df_slice_v2.columns.duplicated()]" ] }, { "cell_type": "code", "execution_count": 32, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:59:36.794402Z", "start_time": "2024-04-17T14:59:36.753172Z" } }, "outputs": [], "source": [ "df_slice_v3 = df_slice.copy()" ] }, { "cell_type": "code", "execution_count": 33, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:59:37.493136Z", "start_time": "2024-04-17T14:59:36.795687Z" } }, "outputs": [], "source": [ "df_slice_full = pd.concat([df_slice, df_slice_v2], axis=0, ignore_index=True)" ] }, { "cell_type": "code", "execution_count": 34, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:59:37.496560Z", "start_time": "2024-04-17T14:59:37.494422Z" } }, "outputs": [ { "data": { "text/plain": [ "(427504, 69)" ] }, "execution_count": 34, "metadata": {}, "output_type": "execute_result" } ], "source": [ "df_slice_full.shape" ] }, { "cell_type": "code", "execution_count": 35, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:59:38.351549Z", "start_time": "2024-04-17T14:59:37.497586Z" } }, "outputs": [], "source": [ "df_slice_full = df_slice_full.sort_values(by=[\"request_id\", \"preference\"])" ] }, { "cell_type": "code", "execution_count": 36, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:59:38.378154Z", "start_time": "2024-04-17T14:59:38.352846Z" } }, "outputs": [], "source": [ "df_slice = df_slice_full" ] }, { "cell_type": "code", "execution_count": 37, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T14:59:38.459839Z", "start_time": "2024-04-17T14:59:38.379315Z" } }, "outputs": [ { "data": { "text/plain": [ "model_name\n", "chirp-v2-xxl-alpha 266172\n", "chirp-v3-engine-d 84276\n", "chirp-v3-engine-v0 72512\n", "chirp-v2-engine-v12 2988\n", "chirp-v2-engine-v8 944\n", "chirp-v2-engine-v0 398\n", "chirp-v2-engine-jingle 212\n", "chirp-v2-engine-dev 2\n", "Name: count, dtype: int64" ] }, "execution_count": 37, "metadata": {}, "output_type": "execute_result" } ], "source": [ "df_slice[\"model_name\"].value_counts()" ] }, { "cell_type": "code", "execution_count": 46, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T15:04:50.909357Z", "start_time": "2024-04-17T15:04:50.829571Z" } }, "outputs": [ { "data": { "text/plain": [ "is_7b\n", "False 270716\n", "True 156788\n", "Name: count, dtype: int64" ] }, "execution_count": 46, "metadata": {}, "output_type": "execute_result" } ], "source": [ "df_slice[\"is_7b\"] = df_slice[\"model_name\"].str.contains(\"v3\")\n", "df_slice[\"is_7b\"].value_counts()" ] }, { "cell_type": "code", "execution_count": 47, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T15:04:54.886658Z", "start_time": "2024-04-17T15:04:54.885197Z" } }, "outputs": [], "source": [ "# BREAK" ] }, { "cell_type": "markdown", "metadata": {}, "source": [ "## Need to kick out the ones has gpt prompt -- these are pairs with different text inputs" ] }, { "cell_type": "code", "execution_count": 48, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T15:04:55.657496Z", "start_time": "2024-04-17T15:04:55.307502Z" } }, "outputs": [ { "data": { "text/plain": [ "168893" ] }, "execution_count": 48, "metadata": {}, "output_type": "execute_result" } ], "source": [ "# don't have continue at\n", "df_slice[df_slice[\"continue_at\"].isna()][\"request_id\"].nunique()" ] }, { "cell_type": "code", "execution_count": 49, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T15:04:56.720064Z", "start_time": "2024-04-17T15:04:56.649118Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "213752\n" ] } ], "source": [ "final_filtered_requests = df_slice[\"request_id\"].unique()\n", "print(len(final_filtered_requests))" ] }, { "cell_type": "code", "execution_count": 50, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T15:04:57.272352Z", "start_time": "2024-04-17T15:04:57.270864Z" } }, "outputs": [], "source": [ "# df_slice.to_csv(\"/home/tony/Data/Preference/7b_v2/7b_before_recode_20240412\", index=False)" ] }, { "cell_type": "code", "execution_count": 51, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T15:04:59.820195Z", "start_time": "2024-04-17T15:04:57.743297Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "211614 2138\n", "(423228, 70) (4276, 70)\n" ] } ], "source": [ "train_requests, val_requests = train_test_split(\n", " sorted(list(final_filtered_requests)), test_size=0.01, random_state=42\n", ")\n", "print(len(train_requests), len(val_requests))\n", "\n", "train_df = df_slice[df_slice[\"request_id\"].isin(set(train_requests))].copy()\n", "val_df = df_slice[df_slice[\"request_id\"].isin(set(val_requests))].copy()\n", "train_df = train_df.sort_values(by=[\"request_id\", \"preference\"])\n", "train_df = train_df.reset_index()\n", "val_df = val_df.sort_values(by=[\"request_id\", \"preference\"])\n", "val_df = val_df.reset_index()\n", "\n", "print(train_df.shape, val_df.shape)" ] }, { "cell_type": "markdown", "metadata": {}, "source": [ "# Actually make" ] }, { "cell_type": "code", "execution_count": 52, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T15:04:59.823121Z", "start_time": "2024-04-17T15:04:59.821633Z" } }, "outputs": [], "source": [ "# val_df[[\"request_id\", \"metadata\", \"updated_at\", \"user_id\", \"preference\"]].head()" ] }, { "cell_type": "code", "execution_count": 53, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T15:05:16.047139Z", "start_time": "2024-04-17T15:05:00.132102Z" } }, "outputs": [ { "name": "stderr", "output_type": "stream", "text": [ "100%|█████████████████████████████████████████████████████████████████████████████████████████████████████| 423228/423228 [00:15<00:00, 26598.85it/s]" ] }, { "name": "stdout", "output_type": "stream", "text": [ "7,625 hours of 423228 clips, 13.225875 nodes\n" ] }, { "name": "stderr", "output_type": "stream", "text": [ "\n" ] } ], "source": [ "total_duration = 0\n", "for i, row in tqdm.tqdm(train_df.iterrows(), total=len(train_df)):\n", " # we need to alternate between preference: neg, pos\n", " # print(i, row)\n", " try:\n", " assert row[\"preference\"] == (i % 2 == 1)\n", " except:\n", " print(i, row)\n", " total_duration += row[\"duration\"]\n", "print(f\"{round(total_duration / 60 / 60):,} hours of {train_df.shape[0]} clips, {train_df.shape[0] / 8 / 4 / 1000} nodes\")" ] }, { "cell_type": "code", "execution_count": 54, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T15:06:41.638876Z", "start_time": "2024-04-17T15:05:23.491440Z" } }, "outputs": [ { "name": "stderr", "output_type": "stream", "text": [ "100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████| 4276/4276 [01:18<00:00, 54.74it/s]" ] }, { "name": "stdout", "output_type": "stream", "text": [ "Total 4276 clips\n", "38 hours of False\n", "38 hours of True\n", "Done\n" ] }, { "name": "stderr", "output_type": "stream", "text": [ "\n" ] } ], "source": [ "make_dataset(val_df, OUT_DATA_DIR, is_val=True, npz_dir=NPZ_DIR)" ] }, { "cell_type": "code", "execution_count": 55, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T16:52:27.240058Z", "start_time": "2024-04-17T15:06:41.640274Z" } }, "outputs": [ { "name": "stderr", "output_type": "stream", "text": [ "100%|██████████████████████████████████████████████████████████████████████████████████████████████████████| 423228/423228 [1:45:45<00:00, 66.70it/s]\n" ] }, { "name": "stdout", "output_type": "stream", "text": [ "Total 423228 clips\n", "3,820 hours of False\n", "3,800 hours of True\n", "Done\n" ] } ], "source": [ "make_dataset(train_df, OUT_DATA_DIR, is_val=False, npz_dir=NPZ_DIR)" ] }, { "cell_type": "markdown", "metadata": { "ExecuteTime": { "end_time": "2024-01-29T19:46:47.549860Z", "start_time": "2024-01-29T19:46:47.548015Z" } }, "source": [ "# Validation" ] }, { "cell_type": "code", "execution_count": 56, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T16:52:27.280613Z", "start_time": "2024-04-17T16:52:27.241293Z" } }, "outputs": [], "source": [ "# verify\n", "mm = np.memmap(os.path.join(OUT_DATA_DIR, f\"data_val.bin\"), dtype=np.uint16, mode=\"r\")\n", "test_metas = read_jsonl(os.path.join(OUT_DATA_DIR, f\"meta_val.jsonl\"))\n", "test_info = read_json(os.path.join(OUT_DATA_DIR, f\"info_val.json\"))\n", "mm = mm.reshape(-1, 3008, 13)\n", "assert len(mm) == len(test_metas)\n", "assert mm[:100, :, 0].min() >= 0\n", "assert mm[:100, :, 0].max() <= 4000\n", "assert mm[:100, :, 1:].min() >= 0\n", "assert mm[:100, :, 1:].max() <= 2048" ] }, { "cell_type": "code", "execution_count": 57, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T16:52:27.323560Z", "start_time": "2024-04-17T16:52:27.282552Z" } }, "outputs": [], "source": [ "# # randomly listen to some stuff\n", "# from suno_utils.tasks.dac_2c_12cb import preload_models as preload_codec_models\n", "# from suno_utils.tasks.dac_2c_12cb import (\n", "# encode as codec_encode,\n", "# decode_stream_to_full_audio as codec_decode,\n", "# EMBEDDING_RATE as CODEC_EMBEDDING_RATE,\n", "# decode as decode\n", "# )\n", "# os.environ[\"CUDA_VISIBLE_DEVICES\"] = \"3\"\n", "# _ = preload_codec_models(\"/app/suno/tony/v3/dac_2c_25x12.pt\", device=\"cuda\")\n", "# assert len(test_metas) == len(mm)\n", "# idx_list = list(range(len(test_metas)))\n", "# # random.shuffle(idx_list)\n", "# # idx_list = [idx for idx in idx_list if \"text\" in test_metas[idx]]\n", "# print(len(mm))" ] }, { "cell_type": "code", "execution_count": 58, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T16:52:27.386771Z", "start_time": "2024-04-17T16:52:27.324962Z" } }, "outputs": [], "source": [ "# idx = random.choice(test_info[\"perference_0\"][\"idx_list\"])\n", "# assert \"original_duration_s\" in test_metas[idx]\n", "# # positive index should be shifted by 1\n", "# pos_idx = idx + 1\n", "# print(\n", "# \"tags:\",\n", "# test_metas[idx].get(\"tags\") == test_metas[pos_idx].get(\"tags\"),\n", "# test_metas[idx].get(\"tags\"),\n", "# )\n", "# arr = mm[idx, 1:].copy().astype(np.int16)[:, 1:]\n", "# pos_arr = mm[pos_idx, 1:].copy().astype(np.int16)[:, 1:]\n", "# pad_idx_arr = np.where(arr == COARSE_PAD_TOKEN)[0]\n", "# if len(pad_idx_arr) > 0:\n", "# arr = arr[: pad_idx_arr[0], :]\n", "# pos_pad_idx_arr = np.where(pos_arr == COARSE_PAD_TOKEN)[0]\n", "# if len(pos_pad_idx_arr) > 0:\n", "# pos_arr = pos_arr[: pos_pad_idx_arr[0], :]\n", "# a = decode(arr)\n", "# print(\"negative example\", test_metas[idx])\n", "# a.play(compress=False)\n", "# pos_a = decode(pos_arr)\n", "# print(\"positive example\", test_metas[pos_idx])\n", "# pos_a.play(compress=False)\n", "# print(\n", "# \"text:\",\n", "# test_metas[idx].get(\"text\") == test_metas[pos_idx].get(\"text\"),\n", "# test_metas[idx].get(\"text\"),\n", "# )" ] }, { "cell_type": "code", "execution_count": 59, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T16:52:27.455309Z", "start_time": "2024-04-17T16:52:27.388423Z" } }, "outputs": [], "source": [ "# val_df[val_df[\"tags\"] == 'a vibrant blend of experimental jazz fusion, drum-and-bass and swagger fuzzed-out guitars']" ] }, { "cell_type": "code", "execution_count": 60, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T16:52:27.534982Z", "start_time": "2024-04-17T16:52:27.456982Z" } }, "outputs": [], "source": [ "# from collections import Counter\n", "# c = Counter()\n", "# for _, row in df_slice.iterrows():\n", "# # print(row[\"metadata\"])\n", "# for k in ast.literal_eval(row[\"metadata\"]).keys():\n", "# c[k] += 1" ] }, { "cell_type": "code", "execution_count": 61, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T16:52:27.606028Z", "start_time": "2024-04-17T16:52:27.535973Z" } }, "outputs": [], "source": [ "# original_npz_path = f\"/app/suno/data/dpo/7b_npz/{test_metas[idx]['id']}.npz\"\n", "# original_npz_path = \"/app/suno/data/dpo/7b_npz/729c3011-f672-4ccd-8d82-1cbf2b52ff69.npz\"\n", "# original_arr = np.load(original_npz_path)[\"v2_raw\"]" ] }, { "cell_type": "code", "execution_count": 62, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T16:52:27.671201Z", "start_time": "2024-04-17T16:52:27.607491Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "2138 0\n" ] } ], "source": [ "def validation_on_metas(input_metas):\n", "\n", " total_bad = 0\n", " total_good = 0\n", " for idx in range(len(input_metas)):\n", " if idx % 2 == 0:\n", " pos_idx = idx + 1\n", " if input_metas[idx].get(\"tags\") != input_metas[pos_idx].get(\"tags\"):\n", " # print(test_metas[idx].get(\"text\") == test_metas[pos_idx].get(\"text\"), test_metas[idx].get(\"tags\"), test_metas[pos_idx].get(\"tags\"))\n", " total_bad += 1\n", " else:\n", " total_good += 1\n", " print(total_good, total_bad)\n", " return\n", "\n", "\n", "validation_on_metas(test_metas)" ] }, { "cell_type": "code", "execution_count": 63, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T16:52:27.776673Z", "start_time": "2024-04-17T16:52:27.672965Z" } }, "outputs": [], "source": [ "train_info = read_json(os.path.join(OUT_DATA_DIR, f\"info_tr.json\"))" ] }, { "cell_type": "code", "execution_count": 64, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T16:52:27.829468Z", "start_time": "2024-04-17T16:52:27.778289Z" } }, "outputs": [], "source": [ "n_neg_tr = train_info[\"perference_0\"][\"idx_list\"]\n", "n_pos_tr = train_info[\"perference_1\"][\"idx_list\"]\n", "assert len(n_pos_tr) == len(n_neg_tr)" ] }, { "cell_type": "code", "execution_count": 65, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T16:52:27.897790Z", "start_time": "2024-04-17T16:52:27.830540Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "total samples 423228 (423228, 70)\n" ] } ], "source": [ "total_iters = (len(n_neg_tr) + len(n_pos_tr))\n", "print(\"total samples\", total_iters, train_df.shape)" ] }, { "cell_type": "code", "execution_count": 66, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T16:52:27.984869Z", "start_time": "2024-04-17T16:52:27.898780Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "1 epoch per batch 4, total 3306.46875\n" ] } ], "source": [ "print(\"1 epoch per batch 4, total\", total_iters / 8 / 4 / 4)" ] }, { "cell_type": "code", "execution_count": 67, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T16:52:28.568157Z", "start_time": "2024-04-17T16:52:27.985877Z" } }, "outputs": [ { "name": "stdout", "output_type": "stream", "text": [ "Submitted batch job 1397\r\n" ] } ], "source": [ "!cd /home/tony/Work/tony/slurm && sbatch sbatch_dpo" ] }, { "cell_type": "markdown", "metadata": {}, "source": [ "# some gymathtics loading prev data" ] }, { "cell_type": "code", "execution_count": 68, "metadata": { "ExecuteTime": { "end_time": "2024-04-17T16:52:28.573357Z", "start_time": "2024-04-17T16:52:28.570976Z" } }, "outputs": [], "source": [ "# prev_v3_data = \"/app/suno/data/dpo/7v_v20_full/\"\n", "\n", "# test_val_metas = read_jsonl(os.path.join(prev_v3_data, f\"meta_val.jsonl\"))\n", "# test_tr_metas = read_jsonl(os.path.join(prev_v3_data, f\"meta_tr.jsonl\"))\n", "\n", "# all_ids = set()\n", "# for meta in test_val_metas:\n", "# all_ids.add(meta[\"id\"])\n", "# for meta in test_tr_metas:\n", "# all_ids.add(meta[\"id\"])\n", "# print(len(all_ids), len(test_val_metas) + len(test_tr_metas))\n", "\n", "# all_ids = list(all_ids)\n", "# with open(\"/home/tony/Data/Preference/7b_v2/7v_v20_full_recut_id.json\", \"w\") as fp:\n", "# json.dump(all_ids, fp)" ] }, { "cell_type": "code", "execution_count": null, "metadata": {}, "outputs": [], "source": [] } ], "metadata": { "kernelspec": { "display_name": "Python 3 (ipykernel)", "language": "python", "name": "python3" }, "language_info": { "codemirror_mode": { "name": "ipython", "version": 3 }, "file_extension": ".py", "mimetype": "text/x-python", "name": "python", "nbconvert_exporter": "python", "pygments_lexer": "ipython3", "version": "3.10.13" }, "toc": { "base_numbering": 1, "nav_menu": {}, "number_sections": true, "sideBar": true, "skip_h1_title": false, "title_cell": "Table of Contents", "title_sidebar": "Contents", "toc_cell": false, "toc_position": {}, "toc_section_display": true, "toc_window_display": false } }, "nbformat": 4, "nbformat_minor": 2 }